Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples to tedge config list --doc #2583

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

didier-wenzek
Copy link
Contributor

Proposed changes

Add examples to:

  • mqtt.topic_root
  • mqtt.device_topic_id

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2462

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (190b6c9) 75.8% compared to head (403b515) 75.8%.
Report is 5 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
.../tedge_config/src/tedge_config_cli/tedge_config.rs 81.1% <100.0%> (+<0.1%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Contributor

github-actions bot commented Jan 11, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
379 0 3 379 100 57m57.498999999s

Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Copy link
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@didier-wenzek didier-wenzek added this pull request to the merge queue Jan 11, 2024
Merged via the queue into thin-edge:main with commit a30487b Jan 11, 2024
19 checks passed
@didier-wenzek didier-wenzek deleted the fix/tedge-config-doc branch February 7, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants