-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve certificate related documentation #2585
Improve certificate related documentation #2585
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few minor comments.
Currently most of the filenames no longer match the scope of the doc, .e.g the file add_self_signed_trusted.md
, has a title of Cloud Authentication
, and registration.md
has a title of Self-signed Device Certificate
.
We should fix the filenames so that the slugs (e.g. doc url) and the filenames are semi-related so it is easier for developers to find and maintain the docs.
basicConstraints=CA:FALSE | ||
keyUsage = digitalSignature, keyAgreement | ||
extendedKeyUsage = serverAuth, clientAuth | ||
subjectAltName=DNS:$(hostname),DNS:localhost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether it's worth clarifying how this works in case people wish to use an IP address to connect instead. Firstly, it's not unlikely that people will want to connect by something other than localhost or the hostname of the machine, Secondly, when using an IP it's easy to fall into the trap of using e.g. DNS:192.168.0.25
where this should actually be IP:192.168.0.25
(and if you make mistakes here, you'll get next to no help in the error message to enlighten you as to what is wrong).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a note
This has been fixed with 5ae1828 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. My comments have now been addressed.
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
5761e2b
to
f79b243
Compare
Robot Results
|
Proposed changes
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments