Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: make markdown compatible with mdx v3 #2599

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Jan 17, 2024

Proposed changes

  • Prepare markdown docs to be compatible with MDX v3 to enable an upgrade of the doc engine (docusaurus, from v2 to v3).
  • Include PR check task to validate the docs to avoid publishing invalid markdown docs which will prevent the docs from being published
  • Fix broken anchors (as docusaurus v3 can validate broken anchors in addition to broken links)

Notes

The docusaurus website has details about differences and how to upgrade

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller added documentation Improvements or additions to documentation ci/cd Repository management and pipeline topics labels Jan 17, 2024
Copy link
Contributor

github-actions bot commented Jan 17, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
380 0 3 380 100 52m55.958s

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

This is working fine in combination with thin-edge/tedge-docs#55 updating to docusaurus v3
as well as without these updates.

@reubenmiller reubenmiller added this pull request to the merge queue Jan 18, 2024
Merged via the queue into thin-edge:main with commit 0463eb5 Jan 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Repository management and pipeline topics documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants