-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send supported ops message on cmd capability message #2645 #2649
Send supported ops message on cmd capability message #2645 #2649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good in general
Robot Results
|
Codecov ReportAttention:
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. This fix the root cause of flaky test.
$ invoke flake-finder --test-name "Successful log operation" --iterations 10 --clean --suite "Log Operation Child"
------------------------------
Overall: PASSED
Results: 10 iterations, 10 passed, 0 failed
Proposed changes
Make sure that the supported ops message is sent on receipt of a command capability message, if that supported op is not already registered. Previously the log, config and firmware management plugins were relying on the fs-notify mechanism to get their supported ops registered. Now that the fs-notify mechanism is not supported for child devices, reuse the same explicit operation registration mechanism used by
restart
andsoftware_update
operation handlers.Types of changes
Paste Link to the issue
#2645
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments