Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix software type should be reported as "softwareType", not "type" #2652

Conversation

rina23q
Copy link
Member

@rina23q rina23q commented Feb 1, 2024

Proposed changes

Software type is reported as "type" in the PR #2613, however, it should have been "softwareType" according to c8y's document. Refer to here. https://cumulocity.com/guides/reference/device-management-library/#software

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Software type is reported as "type" in the PR thin-edge#2613, however, it should
have been "softwareType" according to c8y's document. Refer to here.
https://cumulocity.com/guides/reference/device-management-library/#software

Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
@rina23q rina23q force-pushed the bugfix/1352/rename-software-list-typr-to-softwareType branch from 4594a0e to 67e3d63 Compare February 1, 2024 14:53
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (8589587) 75.8% compared to head (67e3d63) 75.7%.
Report is 70 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
crates/core/c8y_api/src/json_c8y.rs 90.5% <100.0%> (ø)
crates/core/tedge_api/src/entity_store.rs 92.9% <0.0%> (-0.3%) ⬇️
crates/core/tedge/src/cli/init.rs 0.0% <0.0%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
386 0 3 386 100 58m58.911999999s

Copy link
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I can confirm the review of the spec where the softwareType is the correct property name.

@rina23q rina23q added this pull request to the merge queue Feb 1, 2024
Merged via the queue into thin-edge:main with commit 13902ba Feb 1, 2024
20 checks passed
@rina23q rina23q deleted the bugfix/1352/rename-software-list-typr-to-softwareType branch February 2, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants