Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the tedge dummy plugin #2656

Merged

Conversation

didier-wenzek
Copy link
Contributor

Proposed changes

Remove tedge-dummy-plugin which was only used by tests which are ignored since May 2023.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#1662

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

This test was only in tests which are ignored.

Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (6bb5198) 75.8% compared to head (c909b6a) 76.0%.
Report is 83 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
crates/extensions/c8y_mapper_ext/src/converter.rs 81.1% <100.0%> (+0.1%) ⬆️
...s/c8y_mapper_ext/src/operations/firmware_update.rs 88.6% <80.0%> (+0.4%) ⬆️
...es/extensions/c8y_mapper_ext/src/operations/mod.rs 91.5% <94.8%> (+4.8%) ⬆️
crates/core/tedge_api/src/entity_store.rs 92.9% <0.0%> (ø)
...nsions/c8y_mapper_ext/src/operations/log_upload.rs 88.8% <89.1%> (+0.4%) ⬆️
crates/core/tedge/src/cli/init.rs 0.0% <0.0%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
386 0 3 386 100 57m37.204s

@didier-wenzek didier-wenzek added this pull request to the merge queue Feb 1, 2024
Merged via the queue into thin-edge:main with commit 53395f5 Feb 1, 2024
20 checks passed
@didier-wenzek didier-wenzek deleted the test/remove-tedge-dummy-plugin branch February 7, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants