Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove ci_pipeline workflow and dependencies #2662

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Remove the ci_pipeline workflow and dependencies as it only duplicated the system tests covered by the integration-tests workflow (which uses RobotFramework tests)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

…eady existing system tests from the integration-test workflow

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (862357a) 75.9% compared to head (8181668) 75.9%.
Report is 19 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
crates/core/c8y_api/src/json_c8y.rs 90.5% <100.0%> (ø)
crates/extensions/tedge_config_manager/src/lib.rs 87.7% <94.7%> (ø)
...rates/extensions/tedge_config_manager/src/tests.rs 89.9% <96.1%> (ø)
crates/extensions/tedge_log_manager/src/lib.rs 83.7% <87.5%> (ø)
crates/extensions/tedge_log_manager/src/tests.rs 89.0% <93.7%> (ø)
plugins/tedge_log_plugin/src/lib.rs 0.0% <0.0%> (ø)
crates/extensions/tedge_log_manager/src/config.rs 0.0% <0.0%> (ø)
crates/core/tedge_agent/src/agent.rs 0.0% <0.0%> (ø)

... and 3 files with indirect coverage changes

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
389 0 3 389 100 50m48.995s

@reubenmiller reubenmiller added this pull request to the merge queue Feb 2, 2024
Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup of our old stuff 👍

Merged via the queue into thin-edge:main with commit 8d3f310 Feb 2, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Repository management and pipeline topics theme:testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants