Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "upload HEAD coverage" workflow #2679

Merged

Conversation

Bravo555
Copy link
Contributor

@Bravo555 Bravo555 commented Feb 5, 2024

Proposed changes

As we have started using the merge queue which is the new "future main" and merge by squashing is also no longer possible, the workflow is no longer necessary.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca154f9) 76.0% compared to head (4db4770) 75.9%.
Report is 12 commits behind head on main.

Additional details and impacted files

see 5 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
390 0 3 390 100 1h1m32.269s

@Bravo555 Bravo555 added this pull request to the merge queue Feb 5, 2024
@reubenmiller
Copy link
Contributor

@Bravo555 does it make sense to consolidate this workflow with the Pull Request Checks, as it seems like a duplication to me...if so, can you create a new ticket to remove the duplication in function?

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2024
@Bravo555 Bravo555 force-pushed the fix/2678/head-coverage-disk-space branch from 569ab6c to 191d7d7 Compare February 5, 2024 11:25
As we have started using the merge queue which is the new "future main"
and merge by squashing is also no longer possible, the workflow is no
longer necessary.

Signed-off-by: Marcel Guzik <marcel.guzik@inetum.com>
@Bravo555 Bravo555 force-pushed the fix/2678/head-coverage-disk-space branch from 191d7d7 to 4db4770 Compare February 5, 2024 11:26
@Bravo555 Bravo555 changed the title Free diskspace before running HEAD coverage Remove "upload HEAD coverage" workflow Feb 5, 2024
Copy link
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Good to remove duplication (and using unnecessary runner resources).

@Bravo555 Bravo555 added this pull request to the merge queue Feb 5, 2024
Merged via the queue into thin-edge:main with commit fb0a523 Feb 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants