-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tedge-apt-plugin update list missing keep config options #2681
tedge-apt-plugin update list missing keep config options #2681
Conversation
a. Respect tedge config "apt.dpk.options.config" b. Add "--allow-downgrades" and "--no-install-recommends" options for all apt-get install commands c. Add DEBIAN_FRONTEND "noninteractive" as environment variable for all apt-get commands Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
Codecov ReportAttention:
Additional details and impacted files
|
Robot Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From an apt command point of view, I can confirm that the commands and test is good.
Though wait for a Rust review before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Nicely done. This refactoring will help avoiding the same kind of issues.
That said, this PR description is not correct: it doesn't address #2666
Sorry that was my fault, I linked the wrong ticket...updating now. |
Proposed changes
Refactor tedge-apt-plugin to move logic to a common area. It solves the linked tickets.
The systems tests were updated to improve coverage for the keep config options which was previously erroneously passing due to using manual
tedge-apt-plugin install
commands rather than installing packages from the cloud which uses a different code path to install packages.Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments