Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tedge-apt-plugin update list missing keep config options #2681

Conversation

rina23q
Copy link
Member

@rina23q rina23q commented Feb 5, 2024

Proposed changes

Refactor tedge-apt-plugin to move logic to a common area. It solves the linked tickets.

The systems tests were updated to improve coverage for the keep config options which was previously erroneously passing due to using manual tedge-apt-plugin install commands rather than installing packages from the cloud which uses a different code path to install packages.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

a. Respect tedge config "apt.dpk.options.config"
b. Add "--allow-downgrades" and "--no-install-recommends" options for
all apt-get install commands
c. Add DEBIAN_FRONTEND "noninteractive" as environment variable for all
apt-get commands

Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
Signed-off-by: Rina Fujino <rina.fujino.23@gmail.com>
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 50 lines in your changes are missing coverage. Please review.

Comparison is base (ca154f9) 76.0% compared to head (c3eb394) 75.9%.
Report is 28 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
plugins/tedge_apt_plugin/src/lib.rs 24.4% <0.0%> (-1.3%) ⬇️

... and 7 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 5, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
390 0 3 390 100 55m44.457s

Copy link
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From an apt command point of view, I can confirm that the commands and test is good.

Though wait for a Rust review before merging.

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Nicely done. This refactoring will help avoiding the same kind of issues.

That said, this PR description is not correct: it doesn't address #2666

@reubenmiller
Copy link
Contributor

Approved. Nicely done. This refactoring will help avoiding the same kind of issues.

That said, this PR description is not correct: it doesn't address #2666

Sorry that was my fault, I linked the wrong ticket...updating now.

@reubenmiller reubenmiller added this pull request to the merge queue Feb 5, 2024
Merged via the queue into thin-edge:main with commit 0f35e21 Feb 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants