Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/clarify configuration tools #2682

Merged

Conversation

didier-wenzek
Copy link
Contributor

@didier-wenzek didier-wenzek commented Feb 5, 2024

Proposed changes

  • Move the whole content of the Configuration Tools page to the Configuration index page
  • Move the example to the Configuration index page
  • Remove unnecessarily repeated content

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2641

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@didier-wenzek didier-wenzek marked this pull request as draft February 5, 2024 18:04
@reubenmiller reubenmiller added documentation Improvements or additions to documentation theme:configuration Theme: Configuration management theme:cli Theme: cli related topics labels Feb 6, 2024
@didier-wenzek didier-wenzek marked this pull request as ready for review February 6, 2024 10:41
Copy link
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. Approved

Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
@reubenmiller reubenmiller mentioned this pull request Feb 6, 2024
17 tasks
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
390 0 3 390 100 59m39.747999999s

Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
The content has been moved to the Configuration index page.

Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
@didier-wenzek didier-wenzek force-pushed the docs/clarify-configuration-tools branch from 84bebe8 to 748c295 Compare February 6, 2024 13:42
@didier-wenzek didier-wenzek added this pull request to the merge queue Feb 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2024
@didier-wenzek didier-wenzek added this pull request to the merge queue Feb 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2024
@reubenmiller reubenmiller added this pull request to the merge queue Feb 6, 2024
Merged via the queue into thin-edge:main with commit fd0bb11 Feb 6, 2024
18 checks passed
@didier-wenzek didier-wenzek deleted the docs/clarify-configuration-tools branch February 7, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation theme:cli Theme: cli related topics theme:configuration Theme: Configuration management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants