Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry internal id lookup when not found #2533 #2690

Merged

Conversation

albinsuresh
Copy link
Contributor

@albinsuresh albinsuresh commented Feb 7, 2024

Proposed changes

Even if the internal ID lookup fails on the initial attempt (presumably because of delays in the creation of the device), retry a few more times before failing.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (153b90f) 75.9% compared to head (449f42b) 76.9%.
Report is 12 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
crates/core/c8y_api/src/http_proxy.rs 75.1% <100.0%> (ø)
crates/extensions/c8y_http_proxy/src/lib.rs 57.4% <0.0%> (-3.4%) ⬇️
crates/extensions/c8y_http_proxy/src/tests.rs 92.8% <93.5%> (+0.9%) ⬆️
crates/extensions/c8y_http_proxy/src/actor.rs 52.0% <59.4%> (+3.2%) ⬆️

... and 80 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
391 0 3 391 100 58m11.363s

Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@albinsuresh albinsuresh added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
@albinsuresh albinsuresh added this pull request to the merge queue Feb 9, 2024
Merged via the queue into thin-edge:main with commit 5d2b1be Feb 9, 2024
20 checks passed
@reubenmiller reubenmiller added this to the 1.0.1 milestone Feb 15, 2024
@albinsuresh albinsuresh deleted the fix/2533/retry-get-internal-id branch March 22, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants