Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated and unused plugins #2709

Merged

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Feb 13, 2024

Proposed changes

Cleaning up project and removing the following:

  • Remove the deprecated binaries
    • c8y-configuration-plugin
    • c8y-log-plugin
    • tedge-configuration-plugin (already part of the multi-call binary)
    • tedge-log-plugin (already part of the multi-call binary)
  • Remove main.rs files from crates which are provided under the multi-call tedge binary
  • Remove sawtooth-publisher (as it was not used and not maintained - still using older v0 MQTT API)
  • Remove build logic to handle test packages as there are no longer any test packages
  • Default build setting to skip building of deprecated packages (though currently there are none)

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e25b52) 76.9% compared to head (43495f2) 77.3%.
Report is 5 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
...edge_config/src/system_services/managers/config.rs 89.5% <ø> (-0.4%) ⬇️

... and 10 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 13, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
386 0 3 386 100 51m17.933s

@reubenmiller reubenmiller marked this pull request as ready for review February 13, 2024 18:08
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Copy link
Contributor

@albinsuresh albinsuresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see some references to the old plugins in the bootstrap.sh and the uninstall-thin-edge_io.sh scripts. Intentional for backward compatibility?

ci/build_scripts/build.sh Show resolved Hide resolved
ci/package_list.sh Show resolved Hide resolved
configuration/package_scripts/README.md Show resolved Hide resolved
plugins/tedge_apt_plugin/src/main.rs Show resolved Hide resolved
@reubenmiller
Copy link
Contributor Author

I still see some references to the old plugins in the bootstrap.sh and the uninstall-thin-edge_io.sh scripts. Intentional for backward compatibility?

Yes I left those parts parts because they are still used when testing older setups.

We'll have to address the old uninstall script separately as there are some UX questions there...

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
tedge is the only binary/entrypoint needed. All other packages are libraries

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller force-pushed the issue-2698-remove-deprecated-plugins branch from 18c5829 to 43495f2 Compare February 14, 2024 12:38
@reubenmiller reubenmiller added this pull request to the merge queue Feb 14, 2024
Merged via the queue into thin-edge:main with commit 6b1d832 Feb 14, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Developer value
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants