-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove deprecated and unused plugins #2709
chore: remove deprecated and unused plugins #2709
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
b7ff90f
to
588f8ca
Compare
588f8ca
to
ca119ef
Compare
Robot Results
|
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
ca119ef
to
45f2278
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see some references to the old plugins in the bootstrap.sh
and the uninstall-thin-edge_io.sh
scripts. Intentional for backward compatibility?
crates/common/tedge_config/src/system_services/managers/config.rs
Outdated
Show resolved
Hide resolved
crates/common/tedge_config/src/system_services/managers/config.rs
Outdated
Show resolved
Hide resolved
Yes I left those parts parts because they are still used when testing older setups. We'll have to address the old uninstall script separately as there are some UX questions there... |
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
tedge is the only binary/entrypoint needed. All other packages are libraries Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
18c5829
to
43495f2
Compare
Proposed changes
Cleaning up project and removing the following:
main.rs
files from crates which are provided under the multi-call tedge binaryTypes of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments