Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building with build.sh does not appear to work right. #45

Closed
Asmageddon opened this issue Oct 10, 2019 · 10 comments
Closed

Building with build.sh does not appear to work right. #45

Asmageddon opened this issue Oct 10, 2019 · 10 comments
Assignees
Labels

Comments

@Asmageddon
Copy link

Namely, after building using ./build.sh release, ./run.sh does not work - the script finds neither gtkada-env.sh, nor steamsky in the folder it enters, with the former file not found in the repository directory at all, and the latter being placed in ./etc/bin rather than ./bin, and not runnable directly.

Furthermore, it would be nice if the script were to first run a manual check of prerequisite packages being installed one way or another, as well as instructions for building an AppImage.

@thindil thindil self-assigned this Oct 10, 2019
@thindil thindil added the bug label Oct 10, 2019
@thindil
Copy link
Owner

thindil commented Oct 10, 2019

Generally, this bug is in the documentation - run.sh should be used only on debug builds. It is only for development. Probably building of the release should be expanded to build whole AppImage to avoid confusion, but this is bit complicated. Additionally, I plan to replace whole this scripts with my other project (Bob) soon.

@Asmageddon
Copy link
Author

Oh, I see. So how would one run a `./build.sh release' build, then?

@thindil
Copy link
Owner

thindil commented Oct 10, 2019

After successful run ./build.sh release you can copy back file usr/bin/steamsky to bin and then script run.sh should works. But for you it can't find whole GTKAda (this is why it scream for gtkada-env.sh - it should be included in GTKAda).

@Asmageddon
Copy link
Author

So I guess that's just not included in Debian repository's builds of GTKAda, damn. So much for me wanting to skip figuring out how to make the whole thing work without downloading the GTKAda build you link in the readme :F

@thindil
Copy link
Owner

thindil commented Oct 10, 2019

Yes, thats true. I was trying to find it in any Debian package but got zero results. Hard way solution: you can try to edit run.sh script and manually set path to libraries, configuration files etc. Long way solution: I should now have reason to set up Travis CI :) Other solution, you can use docker image: thindil/gnat-gtkada it contains everything what is needed to build the game, without polluting system with alien software ;)

@Asmageddon
Copy link
Author

Well alright, I managed to somehow juryrig the whole thing into working, by copypasting the AppImage's files into the ./bin directory and manually appending --savedir, heh x.x

I'll post a bunch of feedback as another issue, if you don't mind me grouping a lot of items together, in a while.

@thindil
Copy link
Owner

thindil commented Oct 10, 2019

About feedback: yes, definitely needed :)
And if you have build binary, you can always do it in second way - decompress AppImage, put new steamsky binary instead of old and run it everything via AppRun script. Ok, then I see this issue will need two steps:

  1. Create Travis CI version to simply put proper files in AppImage/Windows installation directory.
  2. Clarification in README.md that run.sh works only on debug builds.

@thindil
Copy link
Owner

thindil commented Oct 13, 2019

And this should be fixed too. About Travis CI - at this moment it was added only to development version. If everything will be working properly, will be added to the stable version too. Same as usual: thank you very much for your report and of course, I'm sorry for problems.

@thindil thindil closed this as completed Oct 13, 2019
@Asmageddon
Copy link
Author

@thindil Nice, that's awesome :)

Btw, I'm still cooking up some feedback to send your way, but... ugh I'm not really a functional person and doing things and so on can be hard t.t

@thindil
Copy link
Owner

thindil commented Oct 13, 2019

No problem and no hurry :) We have a lot of time for feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants