fix: fix benchmark bug

things-go · Apr 16, 2024 · 773974f · 773974f
1 parent 93660fe
commit 773974f
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 8 deletions.
diff --git a/benchmark_json_test.go b/benchmark_json_test.go
@@ -10,6 +10,21 @@ import (
 	"go.uber.org/zap/zapcore"
 )
 
+var testNativeZapEncoderConfig = zapcore.EncoderConfig{
+	TimeKey:        "ts",
+	LevelKey:       "level",
+	NameKey:        "logger",
+	CallerKey:      "caller",
+	FunctionKey:    zapcore.OmitKey,
+	MessageKey:     "msg",
+	StacktraceKey:  "stacktrace",
+	LineEnding:     zapcore.DefaultLineEnding,
+	EncodeLevel:    zapcore.LowercaseLevelEncoder,
+	EncodeTime:     zapcore.RFC3339TimeEncoder,
+	EncodeDuration: zapcore.StringDurationEncoder,
+	EncodeCaller:   zapcore.ShortCallerEncoder,
+}
+
 func newDiscardLogger(format string) *log.Log {
 	return log.NewLogger(
 		log.WithAdapter("custom", io.Discard),
@@ -23,9 +38,8 @@ func dfltCtx(ctx context.Context) log.Field {
 func Benchmark_Json_NativeLogger(b *testing.B) {
 	b.ReportAllocs()
 	b.StopTimer()
-	cfg := zap.NewProductionConfig()
 	core := zapcore.NewCore(
-		zapcore.NewJSONEncoder(cfg.EncoderConfig),
+		zapcore.NewJSONEncoder(testNativeZapEncoderConfig),
 		zapcore.AddSync(io.Discard),
 		zapcore.InfoLevel,
 	)
@@ -78,9 +92,8 @@ func Benchmark_Json_Logger_Use_Hook(b *testing.B) {
 func Benchmark_Json_NativeSugar(b *testing.B) {
 	b.ReportAllocs()
 	b.StopTimer()
-	cfg := zap.NewProductionConfig()
 	core := zapcore.NewCore(
-		zapcore.NewJSONEncoder(cfg.EncoderConfig),
+		zapcore.NewJSONEncoder(testNativeZapEncoderConfig),
 		zapcore.AddSync(io.Discard),
 		zapcore.InfoLevel,
 	)

diff --git a/benchmark_text_test.go b/benchmark_text_test.go
@@ -13,9 +13,8 @@ import (
 func Benchmark_Text_NativeLogger(b *testing.B) {
 	b.ReportAllocs()
 	b.StopTimer()
-	cfg := zap.NewDevelopmentConfig()
 	core := zapcore.NewCore(
-		zapcore.NewJSONEncoder(cfg.EncoderConfig),
+		zapcore.NewConsoleEncoder(testNativeZapEncoderConfig),
 		zapcore.AddSync(io.Discard),
 		zapcore.InfoLevel,
 	)
@@ -68,9 +67,8 @@ func Benchmark_Text_Logger_Use_Hook(b *testing.B) {
 func Benchmark_Text_NativeSugar(b *testing.B) {
 	b.ReportAllocs()
 	b.StopTimer()
-	cfg := zap.NewProductionConfig()
 	core := zapcore.NewCore(
-		zapcore.NewJSONEncoder(cfg.EncoderConfig),
+		zapcore.NewConsoleEncoder(testNativeZapEncoderConfig),
 		zapcore.AddSync(io.Discard),
 		zapcore.InfoLevel,
 	)