[Core] Data duplicate detector feature. #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 17, 2022
samson0v
reviewed
Nov 22, 2022
thingsboard_gateway/connectors/mqtt/json_mqtt_uplink_converter.py
Outdated
Show resolved
Hide resolved
|
@devaskim, I will test your changes |
|
@samson0v what about previous PR for |
|
@devaskim not for now. We will see the result of using Duplicate Service. |
|
@samson0v Ok, I just want to ensure that this item is on tracking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion #986
Duplicate detectionis performed after connector has pushed new converted data to gateway 's core module. Sodetectordoesn't depend on any connector specificity.duplicate detectionis disabled.detectorchecks onsendDataOnlyOnChangeoption in that data.falsevalue, data is not checked on duplicates.truevalue, data is checked on duplicates.detectorasks the connector which has pushed data ifduplicate detectionis enabled at all (*) or for the device - the origin of data.(*) In scope of this work ONLY MQTT connector is a bit improved to inform if
duplicate detectionis enabled for this connector. Other connectors will respond thatduplicate detectionis disabled for them. Thus users of other connector should either setsendDataOnlyOnChangetotruein each converted data (in other words, tune theirs converters) or contribute something similar that was done for MQTT connector in this PR.