Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added blackbox tests for Modbus RPC #1289

Merged
merged 21 commits into from
Feb 13, 2024

Conversation

samson0v
Copy link
Contributor

No description provided.

config = load(config)
return config

def change_connector_configuration(self, config_file_path):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method may be useful in other tests, could we move it to the base class for blackbox tests?

sleep(2)

@classmethod
def is_gateway_connected(cls):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be better to check the server attribute "lastConnectedTime" with "active" attribute, because active attribute is not a signal that the device is connected.

@imbeacon imbeacon merged commit 2d68462 into thingsboard:tests-improvement Feb 13, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants