Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] originator attributes node is broken after upgrade to 3.4.3 from 3.3.4.1 #7998

Closed
t0mZ4 opened this issue Jan 26, 2023 · 3 comments
Closed
Assignees

Comments

@t0mZ4
Copy link

t0mZ4 commented Jan 26, 2023

Hello
after upgrading from 3.3.4.1 to 3.4.3 the originator attributes node is broken if "Tell Failure" option is checked.

the issue is, it will report a failure with the missing data keys, but it will also not populate the existing fields into msg or metadata.

so if device has key1 and key2, and you are fetching key1, key2, and key3. and Tell Failure is checked,

you will get error message that key3 is not present in the DB, but key1 and key2 are not populated into OUT message as expected.

expected behavior:

TB reports fails message and reports error with missing datakeys, and existing datakeys are populated into msg or metadata.

actual behavior:

TB reports fails message and reports error, BUT existing keys are not populated into msg or metadata.

image

java.lang.RuntimeException: The following attribute/telemetry keys is not present in the DB:
[SERVER_SCOPE]:[voice_tempAlertLocation]
[LATEST_TS]:[door]

at org.thingsboard.rule.engine.metadata.TbAbstractGetAttributesNode.reportFailures(TbAbstractGetAttributesNode.java:241)
at org.thingsboard.rule.engine.metadata.TbAbstractGetAttributesNode.lambda$safePutAttributes$5(TbAbstractGetAttributesNode.java:129)
at org.thingsboard.common.util.DonAsynchron$1.onSuccess(DonAsynchron.java:55)
at com.google.common.util.concurrent.Futures$CallbackListener.run(Futures.java:1080)
at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1426)
at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:183)
@t0mZ4
Copy link
Author

t0mZ4 commented Jan 26, 2023

workaround: disable Tell Failure

@ashvayka
Copy link
Member

I will let @YevhenBondarenko comment on this.

@t0mZ4 t0mZ4 changed the title [Bug] originator attributes is broken after upgrade to 3.4.3 from 3.3.4.1 [Bug] originator attributes node is broken after upgrade to 3.4.3 from 3.3.4.1 Jan 26, 2023
@YevhenBondarenko
Copy link
Contributor

YevhenBondarenko commented Jan 30, 2023

Hi @t0mZ4
we have checked this issue and a fix will be available on the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants