Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge - notification rules for connection status and errors. Rate limits for Edge events. #10021

Conversation

AndriiLandiak
Copy link
Member

@AndriiLandiak AndriiLandiak commented Jan 19, 2024

Pull Request description

Notification center:

  1. Add EDGE_CONNECTION to inform users about the connectivity status of certain Edge.
  2. Add EDGE_COMMUNICATION_FAILURE: connection problems, bad credentials, failure of processing downlink, uplink

Rate limits:

Add rate limits for the Edge events table: per Tenant and Edge.

General checklist

  • You have reviewed the guidelines document.
  • Labels that classify your pull request have been added.
  • The milestone is specified and corresponds to fix version.
  • Description references specific issue.
  • Description contains human-readable scope of changes.
  • Description contains brief notes about what needs to be added to the documentation.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.
  • Similar PR is opened for PE version to simplify merge. Crosslinks between PRs added. Required for internal contributors only.

Front-End feature checklist

  • Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes;
  • If you change the widget or other API, ensure it is backward-compatible or upgrade script is present.
  • Ensure new API is documented here

Back-End feature checklist

  • Added corresponding unit and/or integration test(s). Provide written explanation in the PR description if you have failed to add tests.
  • If new dependency was added: the dependency tree is checked for conflicts.
  • If new service was added: the service is marked with corresponding @TbCoreComponent, @TbRuleEngineComponent, @TbTransportComponent, etc.
  • If new REST API was added: the RestClient.java was updated, issue for Python REST client is created.
  • If new yml property was added: make sure a description is added (above or near the property).

@AndriiLandiak AndriiLandiak force-pushed the feature/edge-enable-notification-system branch from 235b562 to 88067bd Compare January 19, 2024 08:37
…form about edge's status and errors with connection, bad credentials, etc
@AndriiLandiak AndriiLandiak force-pushed the feature/edge-enable-notification-system branch from 188f1e6 to ad90b44 Compare January 19, 2024 09:22
@ViacheslavKlimov ViacheslavKlimov added the Edge Changes to Edge support label Feb 1, 2024
@ViacheslavKlimov ViacheslavKlimov added this to the 3.6.3 milestone Feb 1, 2024
@ViacheslavKlimov ViacheslavKlimov added the Core Changes to Core label Feb 1, 2024
Copy link
Contributor

@volodymyr-babak volodymyr-babak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashvayka ashvayka merged commit e0a6855 into thingsboard:master Feb 8, 2024
1 of 2 checks passed
@AndriiLandiak AndriiLandiak deleted the feature/edge-enable-notification-system branch February 8, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Changes to Core Edge Changes to Edge support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants