Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dynamic links creation for dashboard gateways devices instances details #10084

Merged
merged 1 commit into from Feb 12, 2024

Conversation

iraznatovskyi
Copy link
Contributor

@iraznatovskyi iraznatovskyi commented Jan 29, 2024

Pull Request description

Added the getEntityDetailsPageURL method to the IWidgetUtils interface for generating entity details page URLs based on ID and entity type depends of the platform. This enables dynamic URL construction within custom functions in gateways.json.

General checklist

  • You have reviewed the guidelines document.
  • Labels that classify your pull request have been added.
  • The milestone is specified and corresponds to fix version.
  • Description references specific issue.
  • Description contains human-readable scope of changes.
  • Description contains brief notes about what needs to be added to the documentation.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.
  • Similar PR is opened for PE version to simplify merge. Crosslinks between PRs added. Required for internal contributors only.

Front-End feature checklist

  • Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes;
  • If you change the widget or other API, ensure it is backward-compatible or upgrade script is present.
  • Ensure new API is documented here

Back-End feature checklist

  • Added corresponding unit and/or integration test(s). Provide written explanation in the PR description if you have failed to add tests.
  • If new dependency was added: the dependency tree is checked for conflicts.
  • If new service was added: the service is marked with corresponding @TbCoreComponent, @TbRuleEngineComponent, @TbTransportComponent, etc.
  • If new REST API was added: the RestClient.java was updated, issue for Python REST client is created.
  • If new yml property was added: make sure a description is added (above or near the property).

@iraznatovskyi iraznatovskyi changed the title Added URL Suffix generation function which is imported and used to generate the correct path for device details Added URL Suffix Generation Function for Device Details Path depends of the platform Jan 29, 2024
@iraznatovskyi iraznatovskyi changed the title Added URL Suffix Generation Function for Device Details Path depends of the platform Added URL Suffix Generation Function for right device details path depends of the platform Jan 29, 2024
@iraznatovskyi iraznatovskyi changed the title Added URL Suffix Generation Function for right device details path depends of the platform Fixed dynamic links creation for dashboard gateways devices instances details Jan 29, 2024
@vvlladd28 vvlladd28 added bug UI UI changes labels Jan 29, 2024
@vvlladd28 vvlladd28 added this to the 3.6.3 milestone Jan 29, 2024
@ikulikov ikulikov merged commit 4cf0aa9 into thingsboard:master Feb 12, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug UI UI changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants