Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dashboard state autocomplete in widget action component #10177

Merged
merged 2 commits into from Feb 27, 2024
Merged

Fixed dashboard state autocomplete in widget action component #10177

merged 2 commits into from Feb 27, 2024

Conversation

Dmitriymush
Copy link
Contributor

@Dmitriymush Dmitriymush commented Feb 13, 2024 •
edited

Pull Request description

BEFORE:
image
image

AFTER:
image
image

General checklist

  • You have reviewed the guidelines document.
  • Labels that classify your pull request have been added.
  • The milestone is specified and corresponds to fix version.
  • Description references specific issue.
  • Description contains human-readable scope of changes.
  • Description contains brief notes about what needs to be added to the documentation.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.
  • Similar PR is opened for PE version to simplify merge. Crosslinks between PRs added. Required for internal contributors only.

Front-End feature checklist

  • Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes;
  • If you change the widget or other API, ensure it is backward-compatible or upgrade script is present.
  • Ensure new API is documented here

vvlladd28
vvlladd28 requested changes Feb 16, 2024
View reviewed changes
...src/app/modules/home/components/widget/lib/settings/common/action/widget-action.component.ts Outdated
@@ -186,7 +186,7 @@ export class WidgetActionComponent implements ControlValueAccessor, OnInit, Vali
}

onDashboardStateInputFocus(): void {
this.actionTypeFormGroup.get('targetDashboardStateId').updateValueAndValidity({onlySelf: true, emitEvent: true});
this.actionTypeFormGroup.get('targetDashboardId').updateValueAndValidity({onlySelf: true, emitEvent: true});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is responsible for when we click on the targetDashboardId field, we get a list of them.
This fix breaks this logic.

@vvlladd28 vvlladd28 added bug UI UI changes WIP Work In Progress labels Feb 16, 2024
@vvlladd28 vvlladd28 added this to the 3.6.3 milestone Feb 16, 2024
@vvlladd28 vvlladd28 removed the WIP Work In Progress label Feb 19, 2024
@ikulikov ikulikov merged commit 7277556 into thingsboard:master Feb 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvlladd28 vvlladd28 vvlladd28 approved these changes

Assignees
No one assigned
Labels
bug UI UI changes
Projects
None yet
Milestone
3.6.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dmitriymush @vvlladd28 @ikulikov