Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility of setting the value range manually in the Signal Strength widget configuration #10226

Merged
merged 3 commits into from Feb 27, 2024

Conversation

jktu2870
Copy link
Contributor

@jktu2870 jktu2870 commented Feb 19, 2024

Before

How to demo somethings that hadn't existed before?

After

Peek 2024-02-15 14-06

Pull Request description

The Signal Strength widget has some limitations.
Currently, a value of -100 is the final acceptable value to display on the widget. A value of -100 is hardcoded and is not displayed on the chart.

The customer has a scenario where the value displayed on the widget may be outside of this range (e.g., -130).

Therefore, the customer would like to be able to manually set the values for each range in the way that there is a possibility to configure the color of active/inactive signal bars under the 'Signal strength card style' section:

General checklist

  • You have reviewed the guidelines document.
  • Labels that classify your pull request have been added.
  • The milestone is specified and corresponds to fix version.
  • Description references specific issue.
  • Description contains human-readable scope of changes.
  • Description contains brief notes about what needs to be added to the documentation.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.
  • Similar PR is opened for PE version to simplify merge. Crosslinks between PRs added. Required for internal contributors only.

Front-End feature checklist

  • Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes;
  • If you change the widget or other API, ensure it is backward-compatible or upgrade script is present.
  • Ensure new API is documented here

@jktu2870
Copy link
Contributor Author

Previous PR with comments #10200

@vvlladd28 vvlladd28 added this to the 3.6.4 milestone Feb 19, 2024
@ikulikov ikulikov merged commit 57b5aa5 into thingsboard:master Feb 27, 2024
1 of 2 checks passed
@vvlladd28 vvlladd28 modified the milestones: 3.6.4, 3.6.3 Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants