Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Widget Export] - Added pattern support for widget title in export filenames #10500

Merged

Conversation

rusikv
Copy link
Contributor

@rusikv rusikv commented Apr 4, 2024

Before: export filenames only included the entity name.
After: the widget's default name is also included in the export filename, making it more informative.

See details below with example.

If used pattern in tittle:

Screenshot from 2024-04-04 12-29-23

File name on widget export:

Before:
Screenshot from 2024-05-17 12-41-57

After:
(Additionally added widget default name to file name)
Screenshot from 2024-05-17 12-42-11

General checklist

  • You have reviewed the guidelines document.
  • Labels that classify your pull request have been added.
  • The milestone is specified and corresponds to fix version.
  • Description references specific issue.
  • Description contains human-readable scope of changes.
  • Description contains brief notes about what needs to be added to the documentation.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.
  • Similar PR is opened for PE version to simplify merge. Crosslinks between PRs added. Required for internal contributors only.

Front-End feature checklist

  • Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes;
  • If you change the widget or other API, ensure it is backward-compatible or upgrade script is present.
  • Ensure new API is documented here

Back-End feature checklist

  • Added corresponding unit and/or integration test(s). Provide written explanation in the PR description if you have failed to add tests.
  • If new dependency was added: the dependency tree is checked for conflicts.
  • If new service was added: the service is marked with corresponding @TbCoreComponent, @TbRuleEngineComponent, @TbTransportComponent, etc.
  • If new REST API was added: the RestClient.java was updated, issue for Python REST client is created.
  • If new yml property was added: make sure a description is added (above or near the property).

@rusikv rusikv changed the title Pattern support for widget title on export Pattern support for widget title on widget export Apr 4, 2024
@vvlladd28 vvlladd28 added enhancement UI UI changes labels Apr 5, 2024
@vvlladd28 vvlladd28 added this to the 3.7 milestone Apr 5, 2024
@vvlladd28 vvlladd28 added the WIP Work In Progress label May 6, 2024
@vvlladd28 vvlladd28 removed the WIP Work In Progress label May 17, 2024
@vvlladd28 vvlladd28 changed the base branch from master to release-3.6 May 17, 2024 11:50
@vvlladd28 vvlladd28 changed the base branch from release-3.6 to master May 17, 2024 11:51
@ikulikov ikulikov merged commit 7352803 into thingsboard:master May 22, 2024
2 of 3 checks passed
@vpan1n vpan1n changed the title Pattern support for widget title on widget export [Widget Export] - Added pattern support for widget title in export filenames May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants