[3.4.4] Fix data convertion for BigInteger values that stored in DB as String #8002

ShvaykaD · 2023-01-27T09:06:53Z

Pull Request description

issue: #8001

General checklist

You have reviewed the guidelines document.
PR name contains fix version. For example, "[3.3.4] Hotfix of some UI component" or "[3.4] New Super Feature".
The milestone is specified and corresponds to fix version.
Description references specific issue.
Description contains human-readable scope of changes.
Description contains brief notes about what needs to be added to the documentation.
No merge conflicts, commented blocks of code, code formatting issues.
Changes are backward compatible or upgrade script is provided.
Similar PR is opened for PE version to simplify merge. Required for internal contributors only.

Front-End feature checklist

Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes;
If you change the widget or other API, ensure it is backward-compatible or upgrade script is present.
Ensure new API is documented here

Back-End feature checklist

Added corresponding unit and/or integration test(s). Provide written explanation in the PR description if you have failed to add tests.
If new dependency was added: the dependency tree is checked for conflicts.
If new service was added: the service is marked with corresponding @TbCoreComponent, @TbRuleEngineComponent, @TbTransportComponent, etc.
If new REST API was added: the RestClient.java was updated, issue for Python REST client is created.

…tored in DB as strings

ashvayka · 2023-01-27T12:33:34Z

dao/src/test/java/org/thingsboard/server/dao/sql/query/EntityDataAdapterTest.java

@@ -25,6 +25,7 @@ public class EntityDataAdapterTest {
    public void testConvertValue() {
        assertThat(EntityDataAdapter.convertValue("500")).isEqualTo("500");
        assertThat(EntityDataAdapter.convertValue("500D")).isEqualTo("500D"); //do not convert to Double !!!
-        assertThat(EntityDataAdapter.convertValue("0101010521130565")).isEqualTo("0101010521130565");
+        assertThat(EntityDataAdapter.convertValue("0101010521130565")).isEqualTo("0101010521130565"); //do not convert to Double !!!


You have added check for "Simple double" that contained ".", but I don't see new tests values that contain ".". When do you return Double as double?

Hi @ashvayka,

EntityDataAdapter.convertValue value method always accepts strings as input parameter.

Simple double added to verify that BigInteger value like 89010303310033979663 will not be converted to: 8.901030331003398E19.

Please check the example added in the github issue:

#8001

smatvienko-tb · 2023-01-30T14:51:10Z

dao/src/main/java/org/thingsboard/server/dao/sql/query/EntityDataAdapter.java

@@ -92,8 +92,9 @@ static String convertValue(Object value) {
                }
                try {
                    double dblVal = Double.parseDouble(strVal);
-                    if (!Double.isInfinite(dblVal)) {
-                        return Double.toString(dblVal);
+                    String doubleAsString = Double.toString(dblVal);


Hey! @ShvaykaD

Look at a more optimal way to identify a double type (have a . char).
Another improvement is to verify the string length to asses for long or double string content (let's say 64 chars)
I hope you can add more use cases for conversion as well.
It is essential code that affects data representation.

fix data convertion for BigInteger values(example: SIM, ICCID) that s…

8060c67

…tored in DB as strings

ShvaykaD added the bug label Jan 27, 2023

ShvaykaD added this to the 3.4.4 milestone Jan 27, 2023

ashvayka reviewed Jan 27, 2023

View reviewed changes

ashvayka merged commit b22d31d into thingsboard:master Jan 30, 2023

smatvienko-tb reviewed Jan 30, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[3.4.4] Fix data convertion for BigInteger values that stored in DB as String #8002

[3.4.4] Fix data convertion for BigInteger values that stored in DB as String #8002

ShvaykaD commented Jan 27, 2023 •

edited

ashvayka Jan 27, 2023

ShvaykaD Jan 30, 2023 •

edited

smatvienko-tb Jan 30, 2023

[3.4.4] Fix data convertion for BigInteger values that stored in DB as String #8002

[3.4.4] Fix data convertion for BigInteger values that stored in DB as String #8002

Conversation

ShvaykaD commented Jan 27, 2023 • edited

Pull Request description

General checklist

Front-End feature checklist

Back-End feature checklist

ashvayka Jan 27, 2023

Choose a reason for hiding this comment

ShvaykaD Jan 30, 2023 • edited

Choose a reason for hiding this comment

smatvienko-tb Jan 30, 2023

Choose a reason for hiding this comment

ShvaykaD commented Jan 27, 2023 •

edited

ShvaykaD Jan 30, 2023 •

edited