Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] fix: remove the mandatory sequence of data binding for labelText and requiredText properties #8044

Closed
wants to merge 2 commits into from

Conversation

rjarman
Copy link

@rjarman rjarman commented Feb 6, 2023

Pull Request description

Fix: remove the mandatory sequence of data binding for labelText and requiredText properties

Example:
This sample code will not work because requiredText and labelText property are used after entityType property. So this pull request will remove this mandatory sequence.

<tb-entity-autocomplete
    fxFlex
    [required]="required"
    (entityChanged)="entityLoaded($event)"
    [entityType]="EntityType.DEVICE "
    [requiredText]="requiredText"
    [labelText]="labelText"
    formControlName="entityId">
</tb-entity-autocomplete>

[3.5] fix: remove the mandatory sequence of data binding for labelText and requiredText properties
@vvlladd28
Copy link
Member

Thanks for reporting the problem, but the fix is incomplete because the previous version of the code stops working

@kalutkaz
Copy link
Contributor

Hello @rjarman you can see the fix for this issue here: #8264.

@vvlladd28 vvlladd28 closed this Mar 27, 2023
@rjarman
Copy link
Author

rjarman commented Mar 28, 2023

Thanks for reporting the problem, but the fix is incomplete because the previous version of the code stops working

It should not because it has some basic changes but it's okay @kalutkaz resolved it anyways😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants