Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 'Notify again' dialog in notification center #8784

Conversation

ArtemDzhereleiko
Copy link
Contributor

@ArtemDzhereleiko ArtemDzhereleiko commented Jun 19, 2023

Pull Request description

Fixed: #8783

Before fix: 'Notify again' dialog with template when you click 'Next' stays in the “Compose” tab, and the “Review” tab doesn’t appear.

After fix: everything works fine and tab 'Review' opens.
image
image

General checklist

  • You have reviewed the guidelines document.
  • Labels that classify your pull request have been added.
  • The milestone is specified and corresponds to fix version.
  • Description references specific issue.
  • Description contains human-readable scope of changes.
  • Description contains brief notes about what needs to be added to the documentation.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.
  • Similar PR is opened for PE version to simplify merge. Crosslinks between PRs added. Required for internal contributors only.

Front-End feature checklist

  • Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes;
  • If you change the widget or other API, ensure it is backward-compatible or upgrade script is present.
  • Ensure new API is documented here

@vvlladd28 vvlladd28 added bug UI UI changes labels Jun 26, 2023
@vvlladd28 vvlladd28 added this to the 3.5.2 milestone Jun 26, 2023
@ikulikov ikulikov merged commit ef471e6 into thingsboard:develop/3.5.2 Jun 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug UI UI changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants