Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support basic settings form of custom widgets #9581

Merged
merged 1 commit into from Nov 8, 2023

Conversation

kalutkaz
Copy link
Contributor

@kalutkaz kalutkaz commented Nov 8, 2023

Pull Request description

In the current version of Thingsboard users can't create custom basic settings components, as BasicWidgetConfigComponent isn't shared and registration of basic settings forms doesn't work properly (basic components put into advanced components map as a result system doesn't see basic forms).

This PR share BasicWidgetConfigComponent and update registerWidgetSettingsForms to allow the creation of custom basic settings forms.

General checklist

  • You have reviewed the guidelines document.
  • Labels that classify your pull request have been added.
  • The milestone is specified and corresponds to fix version.
  • Description references specific issue.
  • Description contains human-readable scope of changes.
  • Description contains brief notes about what needs to be added to the documentation.
  • No merge conflicts, commented blocks of code, code formatting issues.
  • Changes are backward compatible or upgrade script is provided.
  • Similar PR is opened for PE version to simplify merge. Crosslinks between PRs added. Required for internal contributors only.

Front-End feature checklist

  • Screenshots with affected component(s) are added. The best option is to provide 2 screens: before and after changes;
  • If you change the widget or other API, ensure it is backward-compatible or upgrade script is present.
  • Ensure new API is documented here

@vvlladd28 vvlladd28 added this to the 3.6.1 milestone Nov 8, 2023
@vvlladd28 vvlladd28 added enhancement UI UI changes labels Nov 8, 2023
@vvlladd28 vvlladd28 changed the title Added support of custom basic settings Added support basic settings form of custom widgets Nov 8, 2023
@ikulikov ikulikov merged commit 7f8d872 into thingsboard:master Nov 8, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants