New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save attributes node fixes #9652
Merged
ashvayka
merged 12 commits into
thingsboard:master
from
ShvaykaD:fix/save-attributes-node
Dec 5, 2023
Merged
Save attributes node fixes #9652
ashvayka
merged 12 commits into
thingsboard:master
from
ShvaykaD:fix/save-attributes-node
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smatvienko-tb
requested changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey!
Thank you for fixing my issue!
The fix looks quite complicated and tests are hard for me to follow.
The main concern is about changing values with non-default.
You can find my thoughts and suggestions below.
application/src/main/java/org/thingsboard/server/service/install/SqlDatabaseUpgradeService.java
Outdated
Show resolved
Hide resolved
...gine-components/src/main/java/org/thingsboard/rule/engine/telemetry/TbMsgAttributesNode.java
Outdated
Show resolved
Hide resolved
...gine-components/src/main/java/org/thingsboard/rule/engine/telemetry/TbMsgAttributesNode.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/thingsboard/server/service/install/SqlDatabaseUpgradeService.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/thingsboard/server/service/install/SqlDatabaseUpgradeService.java
Outdated
Show resolved
Hide resolved
...gine-components/src/main/java/org/thingsboard/rule/engine/telemetry/TbMsgAttributesNode.java
Show resolved
Hide resolved
...-components/src/test/java/org/thingsboard/rule/engine/telemetry/TbMsgAttributesNodeTest.java
Show resolved
Hide resolved
application/src/main/data/json/tenant/device_profile/rule_chain_template.json
Outdated
Show resolved
Hide resolved
application/src/main/data/json/edge/rule_chains/edge_root_rule_chain.json
Outdated
Show resolved
Hide resolved
application/src/main/data/json/tenant/rule_chains/root_rule_chain.json
Outdated
Show resolved
Hide resolved
…de in rule node & minor changes to the tests
application/src/main/java/org/thingsboard/server/service/install/SqlDatabaseUpgradeService.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/thingsboard/server/service/install/SqlDatabaseUpgradeService.java
Outdated
Show resolved
Hide resolved
...-components/src/test/java/org/thingsboard/rule/engine/telemetry/TbMsgAttributesNodeTest.java
Outdated
Show resolved
Hide resolved
...-components/src/test/java/org/thingsboard/rule/engine/telemetry/TbMsgAttributesNodeTest.java
Outdated
Show resolved
Hide resolved
smatvienko-tb
approved these changes
Nov 22, 2023
ashvayka
reviewed
Nov 22, 2023
application/src/main/java/org/thingsboard/server/service/install/SqlDatabaseUpgradeService.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request description
PE PR: https://github.com/thingsboard/thingsboard-pe/pull/2156
PR subject: Node configuration boolean "false" values (wrapped in quotes) are incorrectly displayed on the UI
Additional ctx:
Manual Tests:
before upgrade:
upgrade logs(nodes were upgraded using SQL script)
after upgrade:
Rule chain with test nodes before upgrade: test.json.
General checklist
Front-End feature checklist
Back-End feature checklist