Improved components by changing API usage from getDeviceType/ getAssetЕype to getDeviceProfileName/getAssetProfileName #9935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvlladd28
requested changes
Jan 4, 2024
| @@ -343,7 +344,7 @@ export class EntitySubTypeListComponent implements ControlValueAccessor, OnInit, | |||
| } | |||
| if (subTypesObservable) { | |||
| this.entitySubtypes = subTypesObservable.pipe( | |||
| map(subTypes => subTypes.map(subType => subType.type)), | |||
| map(subTypes => subTypes.map(subType => this.isEntitySubType(subType) ? subType.type : subType.name)), | |||
There was a problem hiding this comment.
Maybe it's better to do fetch type once when receiving data and not every time when filtering
Comment on lines
254
to
257
| subTypes.forEach(subType => { | ||
| const typeName = this.isEntitySubType(subType) ? subType.type : subType.name; | ||
| return !excludeSubTypesSet.has(typeName) && filteredSubTypes.push(typeName); | ||
| }); |
There was a problem hiding this comment.
Maybe it's better to do fetch type once when receiving data and not every time when filtering
| subTypes.forEach(subType => { | ||
| const typeName = this.isEntitySubType(subType) ? subType.type : subType.name; | ||
| return !excludeSubTypesSet.has(typeName) && filteredSubTypes.push(typeName); | ||
| }); | ||
| return filteredSubTypes; | ||
| }), | ||
| publishReplay(1), |
There was a problem hiding this comment.
Please change this deprecated method
| })) | ||
| ); | ||
| } | ||
|
|
||
| getSubTypes(): Observable<Array<EntitySubtype | string>> { | ||
| getSubTypes(): Observable<Array<EntitySubtype | string | EntityInfoData>> { |
There was a problem hiding this comment.
Perhaps it is better to rewrite so the function returns only the string data type?
vvlladd28
requested changes
Jan 8, 2024
Comment on lines
103
to
106
| private deviceProfileService: DeviceProfileService, | ||
| private assetProfileService: AssetProfileService, | ||
| private edgeService: EdgeService, | ||
| private entityViewService: EntityViewService, |
There was a problem hiding this comment.
After refactoring the code, you need to clean the imports.
Comment on lines
129
to
132
| private assetProfileService: AssetProfileService, | ||
| private deviceProfileService: DeviceProfileService, | ||
| private edgeService: EdgeService, | ||
| private entityViewService: EntityViewService, |
There was a problem hiding this comment.
After refactoring the code, you need to clean the imports.
Comment on lines
86
to
89
| private deviceProfileService: DeviceProfileService, | ||
| private assetProfileService: AssetProfileService, | ||
| private edgeService: EdgeService, | ||
| private entityViewService: EntityViewService, |
There was a problem hiding this comment.
After refactoring the code, you need to clean the imports.
vvlladd28
approved these changes
Jan 8, 2024
vvlladd28
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #9321
Related BE - #9776
Before:
scrnli_1_3_2024_3-07-41.PM.webm
After:
scrnli_1_3_2024_3-12-11.PM.webm
General checklist
Front-End feature checklist