changing parseInt to parseFloat so that non-int measurements don't get chopped off #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests ran okay for me so I pulled it in and wrote another unit test for floating point comparisons, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error occurred when using:
Then "post title" should have "font-size" of greater than "26px"
The problem was that 'post title' has a computed font-size of 26.6666px, but in the greater/less comparison, it does a parseInt which rounds that down to 26. I want to measure that the size is between 26 and 28, and so parseFloat allows me to do that.
On a side note, I wasn't able to run the tests for some reason on my computer. Hopefully TravisCI doesn't have trouble.