Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Windows scripts based on TinkerPop #1274

Merged
merged 2 commits into from
Mar 7, 2016

Conversation

pluradj
Copy link
Contributor

@pluradj pluradj commented Mar 4, 2016

#1242

Fixes for gremlin.bat and gremlin-server.bat based off of the TinkerPop3 versions of those files.

  • I tested on Windows 7 and Windows 10 with Cassandra 2.1.13 and Elasticsearch 1.5.2 local on the Windows machine
  • I tested OLAP traversals (Gryo-based) against a remote Linux-based HDFS/YARN/Spark cluster
  • I tested passing scripts in with gremlin.bat -e
  • I tested installing plugins with gremlin-server.bat -i
  • I did not test OLAP against a Windows HDFS/YARN/Spark cluster. It became too much trouble to install -- do people really run Hadoop on Windows :)

I included a logback.xml more as an example, but it doesn't get used since the scripts force log4j ahead of it on the classpath.

It would be simpler to pull in the winutils.exe directly into the build, but I imagine that could complicate licensing concerns.

I didn't tackle a conversion of titan.sh to titan.bat with this PR. I'll open up a separate issue for that. Another separate issue would be adding more Titan-specific support for gremlin.bat -v.

@spmallette
Copy link
Member

Nice PR. Merging - thanks.

spmallette added a commit that referenced this pull request Mar 7, 2016
fixed Windows scripts based on TinkerPop
@spmallette spmallette merged commit 599ddb3 into thinkaurelius:titan11 Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants