Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add boundary logic #47

Merged
merged 5 commits into from
Jun 20, 2022
Merged

Add boundary logic #47

merged 5 commits into from
Jun 20, 2022

Conversation

jtmiclat
Copy link
Contributor

@jtmiclat jtmiclat commented Jun 16, 2022

Closes #33

Creates a parameter that handles boundaries

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2022

Visit the preview URL for this PR (updated for commit af77a46):

https://geowrangler--pr47-feature-improve-grid-p6aovzwo.web.app

(expires Thu, 23 Jun 2022 10:36:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@jtmiclat
Copy link
Contributor Author

@joshuacortez I've implemented boundary based on our discussion in #33 Can you take a look at https://geowrangler--pr47-feature-improve-grid-p6aovzwo.web.app/tutorial.grids.html#Reusing-boundaries to see if this makes sense or if you have other comments?

@tm-kah-alforja tm-kah-alforja mentioned this pull request Jun 16, 2022
9 tasks
@joshuacortez
Copy link
Contributor

@jtmiclat I looked at https://geowrangler--pr47-feature-improve-grid-p6aovzwo.web.app/tutorial.grids.html#Reusing-boundaries and it makes sense! Just wondered what this cell was for

from importlib import reload

reload(grids)

@jtmiclat
Copy link
Contributor Author

Whoops, leftover when I was debugging something. It reloads libraries in case you import them but then changed the module. Ill remove it.

@jtmiclat jtmiclat marked this pull request as ready for review June 16, 2022 10:33
@jtmiclat jtmiclat requested a review from butchtm June 16, 2022 10:33
@butchtm butchtm merged commit b62f0ac into master Jun 20, 2022
@butchtm butchtm deleted the feature/improve-grid-perfomance branch June 20, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Decoupling the bounding box from the AOIs
3 participants