-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for distant AOIs for grid generation #55
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Visit the preview URL for this PR (updated for commit 162909d): https://geowrangler--pr55-docs-document-grid-p-q6ichi76.web.app (expires Thu, 07 Jul 2022 01:59:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Hi @joshuacortez, Can you check if this aligns with what you mentioned in #35 |
Hello @jtmiclat , tried to run the colab notebook but encountered an error when loading the admin_grids geojson. It couldn't find the file in the data directory. Thanks!
|
@joshuacortez Fixed! Pls, try it out again. Please use this link as the button that opens collab points to master and not this branch https://colab.research.google.com/github/thinkingmachines/geowrangler/blob/docs/document-grid-perfomance/notebooks/tutorial.grids.ipynb |
Thanks for the corrections! I looked at it and the example of having a ~50 square AOIs (divided into large cells of 1km) might not be representative of some actual use cases? Curious about the performance of dividing irregularly shaped polygons across a country into granular cells (e.g. 100m instead of 1km). That's where performance concerns (speed, memory) might be more apparent. I can help out with this if ever too. |
@joshuacortez Can you provide some irregular polygons we can try? |
Alright, provided test polygon AOIs in this GPKG file Parameters I used:
Some benchmarked runtime results using previous code:
|
@joshuacortez I ran the benchmark on colab (Single core with ~14GB ram). It is very similar to what you mentioned. |
Awesome, thanks @jtmiclat! This looks pretty good. I ran it on a local machine with similar specs |
I wonder if it makes sense to have a function that takes in a geodataframe of multiple AOIs instead of manually iterating through each AOI and making separate geodataframes. I don't feel too strongly about this but might look "cleaner" from a user perspective |
Moving this to the discussion! |
Closes #35
Closes #59
Closes #60