Skip to content

Commit

Permalink
log error when parse post data error in development env, fix #227
Browse files Browse the repository at this point in the history
  • Loading branch information
welefen committed Dec 25, 2015
1 parent a2a1757 commit 34d2a86
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 7 deletions.
23 changes: 17 additions & 6 deletions src/bootstrap/_payload.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,13 @@ think.middleware('parse_form_payload', http => {
form.on('close', () => {
deferred.resolve(http);
});
form.on('error', () => {
form.on('error', err => {
http.res.statusCode = 400;
http.end();
//log error
if(http.config('post.log_error')){
think.log(err);
}
});
form.parse(http.req);
return deferred.promise;
Expand Down Expand Up @@ -83,9 +87,13 @@ think.middleware('parse_single_file_payload', http => {
let filepath = uploadDir + '/' + name + path.extname(filename).slice(0, 5);
let stream = fs.createWriteStream(filepath);
http.req.pipe(stream);
stream.on('error', () => {
stream.on('error', err => {
http.res.statusCode = 400;
http.end();
//log error
if(http.config('post.log_error')){
think.log(err);
}
});
stream.on('close', () => {
http._file.file = {
Expand Down Expand Up @@ -118,7 +126,12 @@ think.middleware('parse_json_payload', http => {
return http.getPayload().then(payload => {
try{
http._post = think.extend(http._post, JSON.parse(payload));
}catch(e){}
}catch(err){
//log error
if(http.config('post.log_error')){
think.log(new Error('JSON.parse error, payload is not a valid JSON data'));
}
}
});
});

Expand All @@ -135,9 +148,7 @@ think.middleware('parse_querystring_payload', http => {
}

return http.getPayload().then(payload => {
try{
http._post = think.extend(http._post, querystring.parse(payload));
}catch(e){}
http._post = think.extend(http._post, querystring.parse(payload));
});
});

Expand Down
3 changes: 3 additions & 0 deletions src/config/env/development.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ let configs = {
db: {
log_sql: true,
log_connect: true
},
post: {
log_error: true
}
};

Expand Down
3 changes: 2 additions & 1 deletion src/config/post.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,6 @@ export default {
max_fields_size: 2 * 1024 * 1024, //2M,
single_file_header: 'x-filename',
file_upload_path: runtimePrefix + '/upload',
file_auto_remove: true
file_auto_remove: true,
log_error: false
};

0 comments on commit 34d2a86

Please sign in to comment.