Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Blue variant #37

Closed
wants to merge 1 commit into from
Closed

Added Blue variant #37

wants to merge 1 commit into from

Conversation

BrianGilbert
Copy link

This is a fairly major restructure of the file structure but makes it a lot easier to add color variants without having to duplicate all the files, based of the Soda theme file structure

@joelfillmore
Copy link
Member

I reorganized the files to better match the Soda structure. Following Soda, I went with "Flatland Dark" in case we ever decide to add a light theme as well.

I looked briefly through this pull request and it looks like the main change is the blue tabs. I wonder if it would be possible to add "flatland_blue_tabs" as an option, similar to how "flatland_square_tabs" was added? That would eliminate the overhead of trying to keep two sublime-theme files in sync.

@aapis
Copy link
Collaborator

aapis commented Apr 28, 2013

What about a "flatland_tab_color" setting? It could (theoretically) support any colour as long as there are associated theme resources.

@BrianGilbert
Copy link
Author

I have no problem with that however the tabs weren't the only images changed in my variant, I also changed the sidebar highlight colour.

Bear in mind that to do true colour theme changes you will probably need to change the icons for search as well as the file browser highlight.

@BrianGilbert
Copy link
Author

see #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants