Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows requests from API user objects #113

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Allows requests from API user objects #113

merged 2 commits into from
Feb 24, 2023

Conversation

aprice42
Copy link
Contributor

@aprice42 aprice42 commented Feb 24, 2023

Fix for #112

As noted in that issue as of the v3 release of this library non-supported API calls such as this would no longer be possible:

$mailchimp_api = mailchimp_get_api_object('MailchimpLists');
$mailchimp_api->request('DELETE', '/lists/{list_id}/interest-categories/{interest_category_id}/interests/{interest_id}', $tokens);

The change in this PR would fix the BC break introduced in the v3 release.

@Berdir
Copy link

Berdir commented Feb 24, 2023

Didn't test but that's what I expect will work, yes.

@aprice42
Copy link
Contributor Author

Great! My tests all worked as expected, going to merge this in and get this into another release.

@aprice42 aprice42 merged commit 0616e3a into main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants