I just submitted code and now I want to make sure it's ready for primetime!!!
In order to do that I need to first go through the below checklist entitled "For Me" because I respect my coworkers and want to get this PR into the best place possible before i ask for their time. When i am done i will then summon reviewers for feedback and comment. These reviewers will have about a week to complete their review.
If they do not review in the time alloted or have no change requests or blocking concerns the person who opened the pull request will apply the "Ready to merge" label which will ping the Keepers of Faith to press the merge button.
What do you think of a person who only does the bare minimum?
- I've read the Contributing Code Guide
- I've updated this PR with the latest code from
master - I've made sure my code fits into the right place
- I've done a cursory QA pass of my code locally
- I've written an acceptance test below for the reviewer
- I've ensured all automated tests pass
- I've connected this PR to an issue
- I've written a unit or functional test for my code
- I've updated this repo's README if my code changes it
- I've updated relevant documentation it my code changes it
- I've requested a review with relevant people
- I've moved this ticket into the "Ready for review" swimlane