Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[observability] exclude health probes and metrics endpoints from traces #98

Closed
9 tasks done
ThorstenHans opened this issue Feb 15, 2023 · 2 comments
Closed
9 tasks done

[observability] exclude health probes and metrics endpoints from traces #98

ThorstenHans opened this issue Feb 15, 2023 · 2 comments
Assignees
@ThorstenHans
Labels
prio-1 💥

Comments

@ThorstenHans
Copy link
Contributor

ThorstenHans commented Feb 15, 2023 •
edited

Currently, all calls to /healthz and /metrics are traced. Those should be excluded.

  • OrdersService
  • ProductsService
  • Gateway
  • AuthenticationService
  • ShippingService
  • OrderMonitorService
  • NotificationService
  • PriceDropService
  • PriceWatcherService
@ThorstenHans ThorstenHans self-assigned this Feb 15, 2023
@ThorstenHans ThorstenHans changed the title [observability] exclude health probes and metrics endpoints from traces and metrics [observability] exclude health probes and metrics endpoints from traces Feb 15, 2023
ThorstenHans added a commit that referenced this issue Feb 15, 2023
@ThorstenHans
chore(*): Disable traces of /metrics and /healthz in all .NET components
1c4b58e 
Signed-off-by: Thorsten Hans <thorsten.hans@gmail.com>

#98
ThorstenHans added a commit that referenced this issue Feb 15, 2023
@ThorstenHans
chore(otel): Prevent tracing of /metrics and /healthz endpoints in Or…
176875b 
…derMonitorService

Signed-off-by: Thorsten Hans <thorsten.hans@gmail.com>

#98
ThorstenHans added a commit that referenced this issue Feb 15, 2023
@ThorstenHans
chore(otel): Prevent tracing of /metrics and /healthz endpoints in Sh…
fc31413 
…ippingService

Signed-off-by: Thorsten Hans <thorsten.hans@gmail.com>

#98
ThorstenHans added a commit that referenced this issue Feb 15, 2023
@ThorstenHans
chore(otel): Prevent tracing of /metrics and /healthz endpoints in No…
455b20d 
…tificationService

Signed-off-by: Thorsten Hans <thorsten.hans@gmail.com>

#98
@ThorstenHans
Copy link
Contributor Author

must be merged into main

@ThorstenHans
Copy link
Contributor Author

With merging ab56d9e into main this is finally done ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThorstenHans ThorstenHans

Labels
prio-1 💥
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ThorstenHans