Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix UnicodeDecodeError on Windows #32

Merged
merged 2 commits into from
Jun 1, 2020

Conversation

chedidelias
Copy link
Contributor

This fixed it on my computer. However I would need someone to confirm it doesn't break anything on mac :)

This fixed it on my computer
@thinkwelltwd
Copy link
Owner

Thanks for the PR! The docstring says:

The default encoding is platform dependent,

so that seems to explain the problem, and I'm quite sure there'll be no regressions on other platforms.

However, you passed in the kwarg as -encoding instead of encoding that the function signature calls for. If you fix that and Travis passes, I'll merge the PR.

@chedidelias
Copy link
Contributor Author

Thanks for the PR! The docstring says:

The default encoding is platform dependent,

so that seems to explain the problem, and I'm quite sure there'll be no regressions on other platforms.

However, you passed in the kwarg as -encoding instead of encoding that the function signature calls for. If you fix that and Travis passes, I'll merge the PR.

Removed it, sorry for the typo!

@thinkwelltwd thinkwelltwd merged commit f56b6eb into thinkwelltwd:master Jun 1, 2020
@thinkwelltwd
Copy link
Owner

Thanks for the PR! Fixes #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants