Fixed ZeroDivisionError when UA contains punctuation only #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an edge case when
alphabetic_chars / len(app_no_punc) < threshold
fails withZeroDivisionError
. It's extremely rare in real-world data (as in "couple of dozens per hundreds of millions"-rare), but quite destructive nevertheless.One of the inputs that cause this is
"%7C%7C%27"
, which decodes into"||'"
and leads (after punctuation stripping) to0/0
evaluation.Not sure if an empty string should result in
True
orFalse
to be returned, but sinceTrue
effectively forces the whole thing to be discarded (and such strings should definitely be discarded) it makes more sense to me.