Fix [L-2] Missing sanity checks for PrimarySale and PlatformFee recip…

…ients
thirdweb-dev · Sep 26, 2023 · 97949b8 · 97949b8
1 parent c38d61c
commit 97949b8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/contracts/extension/upgradeable/PlatformFee.sol b/contracts/extension/upgradeable/PlatformFee.sol
@@ -64,6 +64,9 @@ abstract contract PlatformFee is IPlatformFee {
         if (_platformFeeBps > 10_000) {
             revert("Exceeds max bps");
         }
+        if (_platformFeeRecipient == address(0)) {
+            revert("Invalid recipient");
+        }
 
         _platformFeeStorage().platformFeeBps = uint16(_platformFeeBps);
         _platformFeeStorage().platformFeeRecipient = _platformFeeRecipient;

diff --git a/contracts/extension/upgradeable/PrimarySale.sol b/contracts/extension/upgradeable/PrimarySale.sol
@@ -52,6 +52,9 @@ abstract contract PrimarySale is IPrimarySale {
 
     /// @dev Lets a contract admin set the recipient for all primary sales.
     function _setupPrimarySaleRecipient(address _saleRecipient) internal {
+        if (_saleRecipient == address(0)) {
+            revert("Invalid recipient");
+        }
         _primarySaleStorage().recipient = _saleRecipient;
         emit PrimarySaleRecipientUpdated(_saleRecipient);
     }