(Q-3) TokenERC721 can have empty URI

thirdweb-dev · Sep 20, 2022 · c49c0e5 · c49c0e5
1 parent 285009b
commit c49c0e5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/contracts/token/TokenERC721.sol b/contracts/token/TokenERC721.sol
@@ -305,6 +305,7 @@ contract TokenERC721 is
         tokenIdToMint = nextTokenIdToMint;
         nextTokenIdToMint += 1;
 
+        require(bytes(_uri).length > 0, "empty uri.");
         uri[tokenIdToMint] = _uri;
 
         _safeMint(_to, tokenIdToMint);

diff --git a/src/test/token/TokenERC721.t.sol b/src/test/token/TokenERC721.t.sol
@@ -307,6 +307,13 @@ contract TokenERC721Test is BaseTest {
         tokenContract.mintTo(recipient, _tokenURI);
     }
 
+    function test_revert_mintTo_emptyURI() public {
+        // mint
+        vm.prank(deployerSigner);
+        vm.expectRevert("empty uri.");
+        tokenContract.mintTo(recipient, "");
+    }
+
     function test_event_mintTo() public {
         string memory _tokenURI = "tokenURI";