[Q-5] Use safeTransferETH instead of low-level call

thirdweb-dev · Apr 1, 2024 · fbde069 · fbde069
1 parent fb8595a
commit fbde069
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/contracts/prebuilts/unaudited/airdrop/Airdrop.sol b/contracts/prebuilts/unaudited/airdrop/Airdrop.sol
@@ -157,10 +157,7 @@ contract Airdrop is EIP712, Initializable, Ownable {
 
         for (uint256 i = 0; i < len; i++) {
             nativeTokenAmount += _contents[i].amount;
-            (bool success, ) = _contents[i].recipient.call{ value: _contents[i].amount }("");
-            if (!success) {
-                revert AirdropFailed();
-            }
+            SafeTransferLib.safeTransferETH(_contents[i].recipient, _contents[i].amount);
         }
 
         if (nativeTokenAmount != msg.value) {

diff --git a/src/test/airdrop/Airdrop.t.sol b/src/test/airdrop/Airdrop.t.sol
@@ -1,7 +1,7 @@
 // SPDX-License-Identifier: Apache-2.0
 pragma solidity ^0.8.0;
 
-import { Airdrop } from "contracts/prebuilts/unaudited/airdrop/Airdrop.sol";
+import { Airdrop, SafeTransferLib } from "contracts/prebuilts/unaudited/airdrop/Airdrop.sol";
 
 // Test imports
 import { TWProxy } from "contracts/infra/TWProxy.sol";
@@ -228,7 +228,7 @@ contract AirdropTest is BaseTest {
         Airdrop.AirdropContentERC20[] memory contents = _getContentsERC20(10);
 
         vm.prank(signer);
-        vm.expectRevert(abi.encodeWithSelector(Airdrop.AirdropFailed.selector));
+        vm.expectRevert(abi.encodeWithSelector(SafeTransferLib.ETHTransferFailed.selector));
         airdrop.airdropNativeToken{ value: 0 }(contents);
 
         // add some balance to airdrop contract, which it will try sending to recipeints when msg.value zero