Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch extension/Multicall #588

Merged
merged 7 commits into from Dec 18, 2023
Merged

Patch extension/Multicall #588

merged 7 commits into from Dec 18, 2023

Conversation

nkrishang
Copy link
Member

A patch to the extension/Multicall.sol file in line with the publicly disclosed incident: https://blog.thirdweb.com/vulnerability-report/ regarding address spoofing via use of multicall together with a forwarder.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (745afa8) 63.87% compared to head (fec1234) 64.08%.

Files Patch % Lines
contracts/lib/Address.sol 0.00% 12 Missing ⚠️
...registry/entrypoint/TWMultichainRegistryRouter.sol 0.00% 2 Missing ⚠️
contracts/base/ERC20Base.sol 0.00% 1 Missing ⚠️
contracts/base/ERC20Drop.sol 0.00% 1 Missing ⚠️
contracts/base/ERC20DropVote.sol 0.00% 1 Missing ⚠️
contracts/base/ERC721Drop.sol 0.00% 1 Missing ⚠️
contracts/base/ERC721LazyMint.sol 0.00% 1 Missing ⚠️
contracts/base/ERC721Multiwrap.sol 0.00% 1 Missing ⚠️
contracts/extension/Multicall.sol 83.33% 1 Missing ⚠️
...rebuilts/account/dynamic/DynamicAccountFactory.sol 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   63.87%   64.08%   +0.20%     
==========================================
  Files         215      215              
  Lines        6627     6632       +5     
==========================================
+ Hits         4233     4250      +17     
+ Misses       2394     2382      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkrishang nkrishang merged commit efd2218 into main Dec 18, 2023
9 checks passed
@nkrishang nkrishang deleted the nk/multicall branch December 18, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant