Skip to content

Commit

Permalink
[SDK] Less strict prebuilt checks to support OSRF variants (#451)
Browse files Browse the repository at this point in the history
  • Loading branch information
joaquim-verges committed Dec 7, 2022
1 parent 64f24f1 commit 3731459
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 38 deletions.
5 changes: 5 additions & 0 deletions .changeset/chatty-bikes-boil.md
@@ -0,0 +1,5 @@
---
"@thirdweb-dev/sdk": patch
---

Less strict prebuilt checks to support OSRF variants
52 changes: 14 additions & 38 deletions packages/sdk/src/evm/contracts/index.ts
@@ -1,3 +1,4 @@
/* eslint-disable @typescript-eslint/no-unused-vars */
import { getPrebuiltInfo } from "../common/legacy";
import { ALL_ROLES } from "../common/role";
import { getSignerAndProvider } from "../core/classes/rpc-connection-handler";
Expand Down Expand Up @@ -56,12 +57,8 @@ export const EditionDropInitializer = {
);
},
getAbi: async (address: string, provider: ethers.providers.Provider) => {
const contractInfo = await assertContractType(
address,
provider,
"edition-drop",
);
return contractInfo.version > 2
const contractInfo = await getContractInfo(address, provider);
return !contractInfo || contractInfo.version > 2
? (await import("@thirdweb-dev/contracts-js/dist/abis/DropERC1155.json"))
.default
: (
Expand Down Expand Up @@ -97,7 +94,6 @@ export const EditionInitializer = {
);
},
getAbi: async (address: string, provider: ethers.providers.Provider) => {
await assertContractType(address, provider, "edition");
return (
await import("@thirdweb-dev/contracts-js/dist/abis/TokenERC1155.json")
).default;
Expand Down Expand Up @@ -129,7 +125,6 @@ export const MarketplaceInitializer = {
);
},
getAbi: async (address: string, provider: ethers.providers.Provider) => {
await assertContractType(address, provider, "marketplace");
return (
await import("@thirdweb-dev/contracts-js/dist/abis/Marketplace.json")
).default;
Expand Down Expand Up @@ -161,7 +156,6 @@ export const MultiwrapInitializer = {
);
},
getAbi: async (address: string, provider: ethers.providers.Provider) => {
await assertContractType(address, provider, "multiwrap");
return (await import("@thirdweb-dev/contracts-js/dist/abis/Multiwrap.json"))
.default;
},
Expand Down Expand Up @@ -193,7 +187,6 @@ export const NFTCollectionInitializer = {
);
},
getAbi: async (address: string, provider: ethers.providers.Provider) => {
await assertContractType(address, provider, "nft-collection");
return (
await import("@thirdweb-dev/contracts-js/dist/abis/TokenERC721.json")
).default;
Expand Down Expand Up @@ -225,12 +218,8 @@ export const NFTDropInitializer = {
);
},
getAbi: async (address: string, provider: ethers.providers.Provider) => {
const contractInfo = await assertContractType(
address,
provider,
"nft-drop",
);
return contractInfo.version > 3
const contractInfo = await getContractInfo(address, provider);
return !contractInfo || contractInfo.version > 3
? (await import("@thirdweb-dev/contracts-js/dist/abis/DropERC721.json"))
.default
: (
Expand Down Expand Up @@ -267,7 +256,6 @@ export const PackInitializer = {
);
},
getAbi: async (address: string, provider: ethers.providers.Provider) => {
await assertContractType(address, provider, "pack");
return (await import("@thirdweb-dev/contracts-js/dist/abis/Pack.json"))
.default;
},
Expand Down Expand Up @@ -299,12 +287,8 @@ export const SignatureDropInitializer = {
);
},
getAbi: async (address: string, provider: ethers.providers.Provider) => {
const contractInfo = await assertContractType(
address,
provider,
"signature-drop",
);
return contractInfo.version > 4
const contractInfo = await getContractInfo(address, provider);
return !contractInfo || contractInfo.version > 4
? (
await import(
"@thirdweb-dev/contracts-js/dist/abis/SignatureDrop.json"
Expand Down Expand Up @@ -344,7 +328,6 @@ export const SplitInitializer = {
);
},
getAbi: async (address: string, provider: ethers.providers.Provider) => {
await assertContractType(address, provider, "split");
return (await import("@thirdweb-dev/contracts-js/dist/abis/Split.json"))
.default;
},
Expand Down Expand Up @@ -376,12 +359,8 @@ export const TokenDropInitializer = {
);
},
getAbi: async (address: string, provider: ethers.providers.Provider) => {
const contractInfo = await assertContractType(
address,
provider,
"token-drop",
);
return contractInfo.version > 2
const contractInfo = await getContractInfo(address, provider);
return !contractInfo || contractInfo.version > 2
? (await import("@thirdweb-dev/contracts-js/dist/abis/DropERC20.json"))
.default
: (await import("@thirdweb-dev/contracts-js/dist/abis/DropERC20_V2.json"))
Expand Down Expand Up @@ -414,7 +393,6 @@ export const TokenInitializer = {
);
},
getAbi: async (address: string, provider: ethers.providers.Provider) => {
await assertContractType(address, provider, "token");
return (
await import("@thirdweb-dev/contracts-js/dist/abis/TokenERC20.json")
).default;
Expand Down Expand Up @@ -447,22 +425,20 @@ export const VoteInitializer = {
);
},
getAbi: async (address: string, provider: ethers.providers.Provider) => {
await assertContractType(address, provider, "vote");
return (await import("@thirdweb-dev/contracts-js/dist/abis/VoteERC20.json"))
.default;
},
};

async function assertContractType(
async function getContractInfo(
address: string,
provider: ethers.providers.Provider,
type: PrebuiltContractType,
) {
const contractInfo = await getPrebuiltInfo(address, provider);
if (!contractInfo || contractInfo.type !== getContractName(type)) {
throw new Error(`Contract is not a ${type}`);
try {
return await getPrebuiltInfo(address, provider);
} catch (e) {
return undefined;
}
return contractInfo;
}

/**
Expand Down

0 comments on commit 3731459

Please sign in to comment.