[SDK] Fix getting domain separator error (#500)

thirdweb-dev · Jan 18, 2023 · 73dc026 · 73dc026
1 parent af32007
commit 73dc026
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/purple-stingrays-pull.md b/.changeset/purple-stingrays-pull.md
@@ -0,0 +1,5 @@
+---
+"@thirdweb-dev/sdk": patch
+---
+
+Getting the domain separator is not a required function. If an error occurs there, the permit it self will not be possible. Therefore, error handling should be performed appropriately.
diff --git a/packages/sdk/src/evm/common/permit.ts b/packages/sdk/src/evm/common/permit.ts
@@ -71,7 +71,14 @@ async function getDomainSeperator(signer: Signer, contractAddress: string) {
   try {
     return await contract.DOMAIN_SEPARATOR();
   } catch (err) {
-    return await contract.getDomainSeperator();
+    try {
+      return await contract.getDomainSeperator();
+    } catch (err2) {
+      console.error(
+        'Error getting domain separator',
+        err2
+      )
+    }
   }
 }