feat: passkey support for in-app wallets #2912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 635df57 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
CodSpeed Performance ReportMerging #2912 will improve performances by 16.77%Comparing Summary
Benchmarks breakdown
|
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2912 +/- ##
==========================================
+ Coverage 64.62% 64.66% +0.04%
==========================================
Files 759 759
Lines 53052 53068 +16
Branches 3097 3100 +3
==========================================
+ Hits 34285 34317 +32
+ Misses 18101 18086 -15
+ Partials 666 665 -1
*This pull request uses carry forward flags. Click here to find out more.
|
chore: save passkey credential again on successful login fix: update post auth to new rpc call to set up wallet hack: temporarily introduce encryptionKey field for passkey to enable developer enc
|
/release-pr |
|
/release-pr |
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: Manan Tank <manantankm@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
/release-pr |
|
/release-pr |
1 similar comment
|
/release-pr |
gregfromstl
approved these changes
May 14, 2024
| setInputMode((prev) => (prev === "email" ? "phone" : "email")); | ||
| }, []); | ||
| const allowSwitchInputMode = isEmailEnabled && isPhoneEnabled; | ||
|
|
||
| const socialLogins = authOptions.filter( |
There was a problem hiding this comment.
Should we keep this and add !== passkey since we're more likely to add more social logins? (have heard Farcaster, X, and Discord mentioned)
|
|
||
| triggered.current = true; | ||
| login(); | ||
| }); |
There was a problem hiding this comment.
Just checking is the missing dependency array intentional?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
The focus of this PR is to update the Connect Modal UI and add Passkey support.
Detailed summary
inAppWallet