Tiny refactor for shortenAddress inputs and docs
#3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 354c7a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
CodSpeed Performance ReportMerging #3004 will not alter performanceComparing Summary
|
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3004 +/- ##
==========================================
- Coverage 64.55% 64.55% -0.01%
==========================================
Files 759 759
Lines 53052 53052
Branches 3096 3093 -3
==========================================
- Hits 34249 34248 -1
- Misses 18138 18139 +1
Partials 665 665
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
approved these changes
May 13, 2024
joaquim-verges
approved these changes
May 13, 2024
| * ``` | ||
| * @utils | ||
| */ | ||
| export function shortenAddress(address: Address, length = 4) { | ||
| export function shortenAddress(address: string, length = 4) { |
There was a problem hiding this comment.
I meant it should leave 4 chars after the 0x on the first slice, like
0xabcd....1234
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
The focus of this PR is to update the
shortenAddressfunction inthirdwebpackage to accept a string parameter instead of anAddress.Detailed summary
shortenAddressfunction now accepts a string parameter