Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ethers6 adapter): allow optional account to be passed to contract.toEthers #3063

Merged
merged 2 commits into from
May 17, 2024

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented May 17, 2024

PR-Codex overview

This PR enhances the ethers6 adapter in thirdweb package to allow passing an optional account for automatic contract signing.

Detailed summary

  • Added optional account parameter to toEthers function in ethers6.ts
  • Modified toEthersContract function to handle the optional account parameter
  • Updated toEthersProvider function to support passing the account parameter
  • Refactored toEthersSigner function to remove the async keyword and return an ethers6.Signer

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: 7488409

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
thirdweb Patch
@thirdweb-dev/sdk Patch
@thirdweb-dev/cli Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Kien Ngo <github@kien.ngo>
Copy link

codspeed-hq bot commented May 17, 2024

CodSpeed Performance Report

Merging #3063 will not alter performance

Comparing jd/imrpove-ethers6-adapter (7488409) with main (85b5a6d)

Summary

✅ 9 untouched benchmarks

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 39.22 KB (0%) 785 ms (0%) 277 ms (-2.29% 🔽) 1.1 s
thirdweb (cjs) 88.71 KB (0%) 1.8 s (0%) 569 ms (+14.04% 🔺) 2.4 s
thirdweb (minimal + tree-shaking) 4.75 KB (0%) 96 ms (0%) 31 ms (+50.05% 🔺) 126 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 21 ms (+84.28% 🔺) 31 ms
thirdweb/react (minimal + tree-shaking) 15.09 KB (0%) 302 ms (0%) 62 ms (+83.65% 🔺) 364 ms

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 63.64%. Comparing base (85b5a6d) to head (7488409).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3063      +/-   ##
==========================================
- Coverage   63.65%   63.64%   -0.02%     
==========================================
  Files         781      781              
  Lines       56050    56062      +12     
  Branches     3189     3192       +3     
==========================================
+ Hits        35678    35679       +1     
- Misses      19703    19714      +11     
  Partials      669      669              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.61% <ø> (ø) Carriedforward from 85b5a6d
packages 63.16% <25.00%> (-0.02%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
packages/thirdweb/src/adapters/ethers6.ts 57.78% <25.00%> (-1.27%) ⬇️

... and 1 file with indirect coverage changes

@jnsdls jnsdls added this pull request to the merge queue May 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2024
@jnsdls jnsdls merged commit f49f8ca into main May 17, 2024
14 of 15 checks passed
@jnsdls jnsdls deleted the jd/imrpove-ethers6-adapter branch May 17, 2024 21:30
@jnsdls jnsdls mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants