Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor react fixes #3067

Merged
merged 4 commits into from
May 18, 2024
Merged

Minor react fixes #3067

merged 4 commits into from
May 18, 2024

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented May 17, 2024

PR-Codex overview

This PR fixes TransactionButton styles override issue and improves test reliability in MediaRenderer.

Detailed summary

  • Fixed TransactionButton styles override with custom styles
  • Updated MediaRenderer test to use waitFor for improved reliability

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: 8898a67

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
thirdweb Patch
@thirdweb-dev/sdk Patch
@thirdweb-dev/cli Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented May 17, 2024

CodSpeed Performance Report

Merging #3067 will not alter performance

Comparing greg/react-tests (8898a67) with main (f49f8ca)

Summary

✅ 9 untouched benchmarks

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 39.22 KB (0%) 785 ms (0%) 2.3 s (+8.47% 🔺) 3.1 s
thirdweb (cjs) 88.71 KB (0%) 1.8 s (0%) 6.4 s (+5.2% 🔺) 8.2 s
thirdweb (minimal + tree-shaking) 4.75 KB (0%) 96 ms (0%) 266 ms (-47.54% 🔽) 361 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 103 ms (+159.34% 🔺) 113 ms
thirdweb/react (minimal + tree-shaking) 15.09 KB (0%) 302 ms (0%) 492 ms (+49.69% 🔺) 794 ms

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.64%. Comparing base (85b5a6d) to head (8898a67).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3067      +/-   ##
==========================================
- Coverage   63.65%   63.64%   -0.02%     
==========================================
  Files         781      781              
  Lines       56050    56062      +12     
  Branches     3189     3189              
==========================================
  Hits        35678    35678              
- Misses      19703    19715      +12     
  Partials      669      669              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.61% <ø> (ø) Carriedforward from f49f8ca
packages 63.16% <100.00%> (-0.02%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...rdweb/src/react/web/ui/TransactionButton/index.tsx 78.50% <100.00%> (ø)

@gregfromstl gregfromstl removed the request for review from MananTank May 18, 2024 00:31
@jnsdls jnsdls added this pull request to the merge queue May 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 18, 2024
@jnsdls jnsdls merged commit b46173f into main May 18, 2024
15 checks passed
@jnsdls jnsdls deleted the greg/react-tests branch May 18, 2024 01:36
@jnsdls jnsdls mentioned this pull request May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants