Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ConnectButton custom theme + customized component in playground #3356

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jun 17, 2024

PR-Codex overview

The focus of this PR is to fix the theming prop for the ConnectButton component and introduce a CustomizedComponent with a custom theme for the button.

Detailed summary

  • Fixed the theming prop for ConnectButton
  • Added CustomizedConnect component with custom theme for ConnectButton
  • Introduced CustomizedComponent for customizing the look of the connect button

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 17, 2024 8:40pm

Copy link

changeset-bot bot commented Jun 17, 2024

🦋 Changeset detected

Latest commit: 2d7ebe2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
thirdweb Patch
@thirdweb-dev/sdk Patch
@thirdweb-dev/cli Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

graphite-app bot commented Jun 17, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges force-pushed the feat/add-customized-connect-component branch from dd472e4 to 0dbb84b Compare June 17, 2024 20:12
Copy link

codspeed-hq bot commented Jun 17, 2024

CodSpeed Performance Report

Merging #3356 will not alter performance

Comparing feat/add-customized-connect-component (2d7ebe2) with main (a9ce10f)

Summary

✅ 9 untouched benchmarks

Copy link
Contributor

github-actions bot commented Jun 17, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.59 KB (0%) 812 ms (0%) 4.3 s (-7.12% 🔽) 5.1 s
thirdweb (cjs) 90.32 KB (0%) 1.9 s (0%) 6.1 s (+15.35% 🔺) 7.9 s
thirdweb (minimal + tree-shaking) 4.75 KB (0%) 95 ms (0%) 478 ms (+132.84% 🔺) 573 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 73 ms (+12.58% 🔺) 83 ms
thirdweb/react (minimal + tree-shaking) 13.47 KB (0%) 270 ms (0%) 301 ms (+0.07% 🔺) 570 ms

@joaquim-verges joaquim-verges marked this pull request as ready for review June 17, 2024 20:18
@joaquim-verges joaquim-verges changed the title feat: add CustomizedConnect component fix: ConnectButton custom theme + customized component in playground Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.89%. Comparing base (a9ce10f) to head (2d7ebe2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3356   +/-   ##
=======================================
  Coverage   62.89%   62.89%           
=======================================
  Files         861      861           
  Lines       63838    63833    -5     
  Branches     3464     3464           
=======================================
- Hits        40151    40150    -1     
+ Misses      23010    23006    -4     
  Partials      677      677           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.60% <ø> (ø) Carriedforward from a9ce10f
packages 62.34% <100.00%> (+<0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...c/react/core/design-system/CustomThemeProvider.tsx 98.14% <100.00%> (+10.01%) ⬆️

... and 2 files with indirect coverage changes

Copy link

graphite-app bot commented Jun 17, 2024

Merge activity

@joaquim-verges joaquim-verges force-pushed the feat/add-customized-connect-component branch from 0dbb84b to 2d7ebe2 Compare June 17, 2024 20:36
@graphite-app graphite-app bot merged commit 2d7ebe2 into main Jun 17, 2024
26 of 27 checks passed
@graphite-app graphite-app bot deleted the feat/add-customized-connect-component branch June 17, 2024 20:38
@jnsdls jnsdls mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants